libstore: Fix makeCopyPathMessage#13756
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 14, 2025
Merged
Conversation
Old code completely ignored query parameters and it seems ok to keep that behavior. There's a lot of code out there that parses nix code like nix-output-monitor and it can't parse messages like: > copying path '/nix/store/wha2hi4yhkjmccqhivxavbfspsg1wrsj-source' from 'https://cache.nixos.org' to 'local://'... Let's not break these tools without a good reason. This goes in line with what other code does by ignoring parameters in logs. The issue is just in detecting the shorthand notations for the store reference - not in printing the url in logs. By default the daemon opens a local store with ?path-info-cache-size=0, so that leads to the erronenous 'local://'.
github-actions
bot
added
the
store
Ericson2314
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Old code completely ignored query parameters and it seems ok to keep that behavior. There's a lot of code out there that parses nix code like nix-output-monitor and it can't parse messages like:
Let's not break these tools without a good reason. This goes in line with what other code does by ignoring parameters in logs.
The issue is just in detecting the shorthand notations for the store reference - not in printing the url in logs.
By default the daemon opens a local store with ?path-info-cache-size=0, so that leads to the erronenous 'local://'.
Context
Broken in #13739 and not completely fixed in #13755
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.